Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons and display appropriate fields for new event types #1082

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Add icons and display appropriate fields for new event types #1082

merged 2 commits into from
Jan 5, 2024

Conversation

kaja-osojnik
Copy link
Collaborator

@kaja-osojnik kaja-osojnik commented Dec 8, 2023 •
edited by lukaw3d
Loading

Related: #893 #906

Screenshots:

Before:
Screenshot 2023-12-08 at 17 10 38
Screenshot 2023-12-08 at 17 11 01

After:
Screenshot 2023-12-08 at 17 11 40
Screenshot 2023-12-08 at 17 11 57

@csillag
Copy link
Contributor

csillag commented Dec 9, 2023

What about CustomIcons/Undelegate.tsx added earlier? Isn't it obsolete now that we have the proper _start and _done events?

@csillag csillag changed the title Add event type icons and display appropriate fields for consensus_accountsundelegate_done, consensus_accountsundelegate_start and consensus_accountsdelegate Add event type icons and display appropriate fields for new event types Dec 9, 2023
lubej
lubej approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs rebase

@kaja-osojnik kaja-osojnik requested a review from lukaw3d December 20, 2023 18:41
@kaja-osojnik kaja-osojnik force-pushed the kaja/new-event-type-icons branch 2 times, most recently from a19691a to 80e09cc Compare January 5, 2024 13:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 84442fd4d2f7aacdcaa4a2083230f403e693ca38
Status:✅ Deploy successful!
Preview URL: https://a52112f9.oasis-explorer.pages.dev

@kaja-osojnik kaja-osojnik force-pushed the kaja/new-event-type-icons branch 2 times, most recently from fa21f74 to 5ca0586 Compare January 5, 2024 13:59
@lukaw3d lukaw3d enabled auto-merge January 5, 2024 13:59
@lukaw3d lukaw3d changed the title Add event type icons and display appropriate fields for new event types Add icons and display appropriate fields for new event types Jan 5, 2024
@lukaw3d lukaw3d force-pushed the kaja/new-event-type-icons branch from 5ca0586 to 84442fd Compare January 5, 2024 14:54
@lukaw3d lukaw3d merged commit 62d2275 into master Jan 5, 2024
8 checks passed
@lukaw3d lukaw3d deleted the kaja/new-event-type-icons branch January 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubej lubej lubej approved these changes

@lukaw3d lukaw3d lukaw3d left review comments

@csillag csillag csillag left review comments

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaja-osojnik @csillag @lukaw3d @lubej